Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock down the source parameter to real system codes #217

Open
rowanmanning opened this issue Feb 15, 2017 · 4 comments
Open

Lock down the source parameter to real system codes #217

rowanmanning opened this issue Feb 15, 2017 · 4 comments
Labels
breaking Will require a major version bump feature New feature request
Projects

Comments

@rowanmanning
Copy link
Member

The source parameter should be checked against a list of valid system codes using @financial-times/source-param-middleware. This will require a v3 release as it's a breaking change.

@rowanmanning rowanmanning added breaking Will require a major version bump feature New feature request labels Feb 15, 2017
@chee chee added this to incoming in Origami ✨ Feb 1, 2020
@chee
Copy link
Member

chee commented Dec 8, 2020

@Financial-Times/origami-core hello, Origami Core.
It looks like Financial-Times/source-param-middleware is now archived.

What should we do about this, and with this issue?

@chee
Copy link
Member

chee commented Dec 8, 2020

@chee
Copy link
Member

chee commented Aug 16, 2021

@JakeChampion
Copy link
Contributor

We could add that code in a log-only mode to track how many are not valid system codes - then we would know which products would need to update their source parameter value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Will require a major version bump feature New feature request
Projects
Origami ✨
  
Backlog
Development

No branches or pull requests

3 participants