Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Add Dialog polyfill #378

Closed
JamesCoyle opened this issue Jan 8, 2020 · 2 comments
Closed

Feature Request - Add Dialog polyfill #378

JamesCoyle opened this issue Jan 8, 2020 · 2 comments
Labels
feature New feature request library Relates to an Origami library

Comments

@JamesCoyle
Copy link

The dialog element is now defined in the HTML 5.2 specification. It is a really useful element that everyone should be using for modal elements as it has many benefits for accessibility and prevents any annoying z-index issues.

Can a polyfill be added for browsers that do not yet implement it? I believe this is the defacto polyfill for the dialog element: https://github.com/GoogleChrome/dialog-polyfill

@Cedric-ruiu
Copy link

+1

@JakeChampion JakeChampion transferred this issue from polyfillpolyfill/polyfill-service Jan 17, 2020
@chee chee added this to incoming in Origami ✨ Feb 25, 2020
@JakeChampion JakeChampion added feature New feature request library Relates to an Origami library labels Mar 24, 2020
@JakeChampion
Copy link
Owner

We can't implement a polyfill for dialog as it also requires adding CSS to the page to polyfill the dialog's design which is something polyfill-library and polyfill.io do not support.

Origami ✨ automation moved this from incoming to complete Dec 16, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2021
@robertboulton robertboulton removed this from Done in Origami ✨ Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature request library Relates to an Origami library
Projects
None yet
Development

No branches or pull requests

3 participants