Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow unused variables if they start with an underscore #390

Merged
merged 3 commits into from
Jan 23, 2020
Merged

allow unused variables if they start with an underscore #390

merged 3 commits into from
Jan 23, 2020

Conversation

JakeChampion
Copy link
Owner

No description provided.

@JakeChampion JakeChampion requested a review from a team January 22, 2020 12:34
@JakeChampion JakeChampion force-pushed the no-unused-var-underscore-allowed branch from e47f318 to 8962725 Compare January 22, 2020 12:35
@JakeChampion JakeChampion force-pushed the no-unused-var-underscore-allowed branch from 8962725 to 29fa636 Compare January 22, 2020 12:36
chee
chee approved these changes Jan 22, 2020
View reviewed changes
Copy link
Collaborator

@chee chee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is lovely

@JakeChampion JakeChampion merged commit b78698a into master Jan 23, 2020
@JakeChampion JakeChampion deleted the no-unused-var-underscore-allowed branch January 23, 2020 00:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chee chee chee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JakeChampion @chee