Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Blob targeting based on MDN data #438

Merged
merged 3 commits into from
Feb 2, 2020
Merged

update Blob targeting based on MDN data #438

merged 3 commits into from
Feb 2, 2020

Conversation

JakeChampion
Copy link
Owner

@JakeChampion JakeChampion requested a review from a team January 27, 2020 16:30
notlee
notlee approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@notlee notlee left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on the basis it doesn't seem to cover arrayBuffer, stream, or text methods which IE doesn't support
Ignore me those would be a separate polyfill

@notlee
Copy link
Contributor

notlee commented Jan 28, 2020 •
edited

@JakeChampion out of interest are you able to tell in an automated way that this polyfill doesn't cover the Blob methods which IE doesn't support, or is it by chance?
Ignore me those would be a separate polyfill

@chee chee added this to incoming in Origami ✨ Feb 1, 2020
@JakeChampion JakeChampion merged commit 3e32e94 into master Feb 2, 2020
Origami ✨ automation moved this from incoming to complete Feb 2, 2020
@JakeChampion JakeChampion deleted the Blob branch February 2, 2020 00:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2021
@robertboulton robertboulton removed this from Done in Origami ✨ Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@notlee notlee notlee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JakeChampion @notlee