Element.prototype.matches not serving to old version of Edge

[jacobg]

What

Element.prototype.matches is not serving to old version of Edge.

Details

That is, this url:
https://cdn.polyfill.io/v3/polyfill.min.js?features=Element.prototype.matches
with this user agent string:
Mozilla/5.0 (Windows NT 10.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.79 Safari/537.36 Edge/14.14393
taken from here:
https://developers.whatismybrowser.com/useragents/parse/288685-edge-windows-edgehtml
does not return the polyfill.

I was first thrown off my the Chrome/51.0.2704.79 token in the useragent string, because the new Edge is Chromium-based. But it seems like a red herring. Edge 38 is from 2016, so it seems that for some reason old versions of Edge that were not based on Chromium still include Chrome in the useragent string.

Is polyfill.io ignoring the Chrome token for old versions of Edge?

[pft]

Same problem here, but for URL and URLSearchParams. These are in fact implemented in Edge, but incorrectly: URLSearchParams do not percent-escape a field that also has spaces in them in old Edge (a bug that gets consistently ignored by the Edge team).

Polyfill.io did use to serve URL to old Edge, but now we have to explicitly add |always.

UA is "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.102 Safari/537.36 Edge/18.18363"

[JakeChampion]

Same problem here, but for URL and URLSearchParams. These are in fact implemented in Edge, but incorrectly: URLSearchParams do not percent-escape a field that also has spaces in them in old Edge (a bug that gets consistently ignored by the Edge team).

Polyfill.io did use to serve URL to old Edge, but now we have to explicitly add |always.

UA is "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.102 Safari/537.36 Edge/18.18363"

This is a different issue, as such I've opened a new issue for it, please subscribe to #540 for updates on when it is fixed :)

[JakeChampion]

What

Element.prototype.matches is not serving to old version of Edge.

Details

That is, this url:
https://cdn.polyfill.io/v3/polyfill.min.js?features=Element.prototype.matches
with this user agent string:
Mozilla/5.0 (Windows NT 10.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.79 Safari/537.36 Edge/14.14393
taken from here:
https://developers.whatismybrowser.com/useragents/parse/288685-edge-windows-edgehtml
does not return the polyfill.

I was first thrown off my the Chrome/51.0.2704.79 token in the useragent string, because the new Edge is Chromium-based. But it seems like a red herring. Edge 38 is from 2016, so it seems that for some reason old versions of Edge that were not based on Chromium still include Chrome in the useragent string.

Is polyfill.io ignoring the Chrome token for old versions of Edge?

We detect it as Edge 14, there is no Edge 38 from what I understand. It looks like Edge versions below 18 need the Element.prototype.matches polyfill, I'v emade a pull-request to serve the polyfill to those browser versions --> #549