Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Report: Comparing boolean to a number with strict operator can never be equal. #714

Closed
thebpc opened this issue Jul 13, 2020 · 1 comment
Closed

Bug Report: Comparing boolean to a number with strict operator can never be equal. #714

thebpc opened this issue Jul 13, 2020 · 1 comment

Comments

@thebpc
Copy link

thebpc commented Jul 13, 2020

A bug Report

What

Please see the description here (as it was found by www.DeepCode.ai): https://www.deepcode.ai/app/gh/financial-times/polyfill-library/def50f2afd152e393da405349d47eb6bf718d732/_/%2Fpolyfills%2FMap%2Fpolyfill.js/javascript%2Fdc%2FIncompatibleTypesInComparison/105/code

File: polyfills/Map/polyfill.js
LOC:105 with semantic flow defining the type of the variable from LOC: 472

Details

a Video describing the problem https://www.youtube.com/watch?v=dc7gLhcuuHQ

Additional information

Feel free to review all other suggestions on your repo, as well as subscribe the repository for continuous monitoring. It is fully free for OSS projects.
https://www.deepcode.ai/app/gh/financial-times/polyfill-library/def50f2afd152e393da405349d47eb6bf718d732/_/dashboard
@origamiserviceuser origamiserviceuser added this to incoming in Origami ✨ Jul 13, 2020
Origami ✨ automation moved this from incoming to complete Jul 13, 2020
@JakeChampion
Copy link
Owner

Thanks for the issue, this is fixed in ae14a38

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2021
@robertboulton robertboulton removed this from Done in Origami ✨ Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JakeChampion @thebpc