Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dotenv dev dependency #10

Merged
merged 2 commits into from
Jan 16, 2019
Merged

Add dotenv dev dependency #10

merged 2 commits into from
Jan 16, 2019

Conversation

chee
Copy link
Collaborator

@chee chee commented Jan 16, 2019

It's required in the updatebrowserstacklist test

a screenshot of dotenv being used in the updatebrowserstacklist test

@CLAassistant
Copy link

CLAassistant commented Jan 16, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@chee
Copy link
Collaborator Author

chee commented Jan 16, 2019

@CLAassistant yes i authorise the finanical times to sell my work of adding a dependency

@JakeChampion JakeChampion merged commit ecd6e3c into master Jan 16, 2019
@JakeChampion JakeChampion deleted the dotenv branch January 17, 2019 10:03
JakeChampion added a commit that referenced this pull request Feb 3, 2020
@JakeChampion
Merge pull request #10 from Financial-Times/dotenv
a3422b0 
Add dotenv dev dependency
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JakeChampion JakeChampion JakeChampion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chee @CLAassistant @JakeChampion