Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browstack android has the same chrome version for all Android versions #1004

Closed
romainmenke opened this issue Feb 28, 2021 · 0 comments · Fixed by #1006
Closed

Browstack android has the same chrome version for all Android versions #1004

romainmenke opened this issue Feb 28, 2021 · 0 comments · Fixed by #1006
Labels
library Relates to an Origami library

Comments

@romainmenke
Copy link
Collaborator

Was testing CI after #997 and noticed that all tests were run for Android where I only expected a single feature test.

This can happen for two reasons :

  • No changes were detected in git (this was not the case)
  • test/polyfills/server.js receives a feature value that is not present testablePolyfills(ua).

I started collecting User Agents from Browserstack a while back and checked these.
https://github.com/mrhenry/web-tests/blob/main/data/uas.json#L1-L86

It seems that Chrome versions are periodically updated in Browserstack for all OS versions. (currently Chrome 86)

Maybe this is ok as the polyfill-service will still give the correct polyfills and we should just take note of this.
With the current test runner we are testing more than really needed which is the best kind of incorrect behaviour.

The only real issue might be with test/polyfills/update-polyfill-targeting.js.
@origamiserviceuser origamiserviceuser added this to incoming in Origami ✨ Feb 28, 2021
@github-actions github-actions bot added the library Relates to an Origami library label Feb 28, 2021
JakeChampion added a commit that referenced this issue Feb 28, 2021
@JakeChampion
Do not run tests on android versions which use the latest version of …
9570270 
…chrome

These test runs are not required because it gives the same results as running on a desktop chrome of the same version.

Resolves #1004
@JakeChampion JakeChampion mentioned this issue Feb 28, 2021
Merged
Origami ✨ automation moved this from incoming to complete Mar 1, 2021
JakeChampion added a commit that referenced this issue Mar 1, 2021
@JakeChampion
Do not run tests on android versions which use the latest version of …
4721ef8 
…chrome

These test runs are not required because it gives the same results as running on a desktop chrome of the same version.

Resolves #1004
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2021
@robertboulton robertboulton removed this from Done in Origami ✨ Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
library Relates to an Origami library
Projects
None yet
Milestone
No milestone
1 participant
@romainmenke