URLSearchParams : [err] keys is not a function #1050
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes : #1048
As far as I can tell there where 2 issues.
URLSearchParams.prototype.sort
)Array.from
was used but with it's own fallback and without declaring it as a dependency. Seems to work better with theArray.from
polyfill.Some WPT tests included here failed, but nothing truly major imho.
CI doesn't run on Firefox 37
test url : http://bs-local.com:9876/test?includePolyfills=yes&always=no&feature=URL
browserstack url : https://live.browserstack.com/dashboard#os=OS+X&os_version=El+Capitan&browser=Firefox&browser_version=37.0&zoom_to_fit=true&full_screen=true&resolution=responsive-mode&speed=1
Test
URLSearchParams iterable methods
covers the issue.This test was previously commented out.