-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serve URL.prototype.toJSON
to Safari <12 and Edge <18.17134
#1058
Conversation
URL.prototype.toJSON
to Safari <12URL.prototype.toJSON
to Safari <12 and Edge <18.17134
@JakeChampion Manually verified that iOS 12 and 13 would work after the config change. If I am not mistaken they receive the polyfill even when config says |
Flaky test run in Edge I think. |
@JakeChampion could you rerun CI on this one? Thank you |
@romainmenke running it now 👍 |
@romainmenke I'm not sure it is a flaky test, I've rerun it several times now and it is always the same browser version and test which fails |
I think I know why it's failing. [[browsers]]
os = "Windows"
os_version = "10"
browser = "edge"
browser_version = "18.0" But the polyfill config has This is causing issues. Thank you for running those tests. I assumed it was flaky because it was a seemingly unrelated polyfill. I'll get back to you with a fix. |
That should do it. If the combination of the test UA and the It is never wrong to run the full list for a UA as running a subset is just an optimization to make CI faster. This PR will run all tests anyway now because |
@romainmenke running on ci now 👍 |
All green now :) |
Thank you @JakeChampion! 🎉 I noticed that the last version wasn't released yet on npm. |
URL
polyfill is loaded in Safari<12
and Edge<18.17134
.This erases native support for
URL.prototype.toJSON
.Matching config for should resolve this.
https://mrhenry.github.io/web-tests/#59933cd3-48cc-4f36-9c52-9ac7b46e5329