fix polyfill combination with time zone data #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeChampion
approved these changes
Jun 14, 2021
romainmenke
deleted the
fix-polyfill-combination-issue-with-time-zone-data--practical-caracal-0be3b85fc7
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see : https://github.com/Financial-Times/polyfill-library/runs/2815491287?check_suite_focus=true
In this test we load all polyfills.
This means both "all" and "golden" are loaded and polyfilled, but they overlap.
Currently there is no mechanism to ensure that two polyfills are not loaded together.
I think that in itself is fine, including both is essentially a user error.
I added a filter in
server.jsto skip "golden" polyfill.Tests for "golden" must work with the data from "all"