-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add polyfill for making MediaQueryList extend the EventTarget interface #1071
Add polyfill for making MediaQueryList extend the EventTarget interface #1071
Conversation
486c133
to
43c98af
Compare
see : santialbo#1 @JakeChampion To really test event listeners on In short :
in tests : var iframe = document.createElement("iframe");
iframe.src = document.getElementById('test-iframe-src').getAttribute('content'); The result is a same origin iframe with all polyfills applied. Feel free to shoot this down :) |
I don't see another way, I like this approach 👍 |
This is now updated with your changes @romainmenke |
The current changes in this pull-request would likely be breaking changes due to the removal of two feature names:
If we wanted to keep this change backwards compatible, we should add those two feature names as aliases to the file |
@JakeChampion Is it possible you were looking at |
Yep 🤦 - good work noticing what I did there 😅 |
As discussed in #1069. I separated the implementation as a new polyfill so it can be included independently.
I have several concerns: