Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publishing releases fails #1073

Closed
romainmenke opened this issue Jul 20, 2021 · 7 comments · Fixed by #1074
Closed

publishing releases fails #1073

romainmenke opened this issue Jul 20, 2021 · 7 comments · Fixed by #1074
Assignees
Labels
library Relates to an Origami library

Comments

@romainmenke
Copy link
Collaborator

https://github.com/Financial-Times/polyfill-library/runs/3114628872

maybe you are aware and had been planning to release this manually later

@origamiserviceuser origamiserviceuser added this to incoming in Origami ✨ Jul 20, 2021
@github-actions github-actions bot added the library Relates to an Origami library label Jul 20, 2021
@JakeChampion
Copy link
Owner

JakeChampion commented Jul 20, 2021

Hi @romainmenke, yes I've been trying to release manually but came across an issue with npm run build not finding the correct localisation dependency for the Intl.NumberFormat.~locale.sr-Latn-BA polyfill

"Polyfill Intl.NumberFormat.~locale.sr-Latn-BA depends on Intl.PluralRules.~locale.sr-Latn, which does not exist within the polyfill-service. Recommended to either add the missing polyfill or remove the dependency."

I've opened a ticket on the upstream project, hopefully it can be resolved and we can release a new version of polyfill-library -- formatjs/formatjs#3058

@JakeChampion JakeChampion self-assigned this Jul 20, 2021
@romainmenke
Copy link
Collaborator Author

Is it possible you were using node 15 or 16?
When I forget to switch to node ±12 I also see errors.

@JakeChampion
Copy link
Owner

I'll try node 12 👍

@JakeChampion
Copy link
Owner

@romainmenke That was the issue 🤦 I'll pin the node version using volta in this project to avoid this in the future

@JakeChampion
Copy link
Owner

version 3.106.0 and 3.107.0 are now published 🎉

Origami ✨ automation moved this from incoming to complete Jul 20, 2021
@JakeChampion JakeChampion linked a pull request Jul 20, 2021 that will close this issue
@romainmenke
Copy link
Collaborator Author

Oh Volta looks cool! We have been using nvm but it's slow :)

@JakeChampion
Copy link
Owner

Oh Volta looks cool! We have been using nvm but it's slow :)

Volta is so fast that the only time I notice it switching is when it needs to download a different node version from the internet - I highly recommend volta 👍

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2022
@robertboulton robertboulton removed this from Done in Origami ✨ Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
library Relates to an Origami library
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants