update browserstack browser list as some devices have been removed such as the Samsung Galaxy Note 4 that we tested on #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oved such as the Samsung Galaxy Note 4 that we tested on
JakeChampion
added
the
current
chee
approved these changes
Oct 18, 2021
…ack devices and browsers
|
@chee I've added some documentation to the contributing.md file about the files and their use. I've also added a comment to the top of both files to mention they are generated via a script and what command to use to regenerate them |
chee
approved these changes
Oct 18, 2021
Comment on lines
+158
to
+171
| ## Updating the list of browsers used during testing on BrowserStack | ||
|
|
||
| The files `test/polyfills/browsers.toml` and `test/polyfills/browserstackBrowsers.toml` are used to map the browser names used in polyfill configuration files to their corresponding record on BrowserStack. | ||
|
|
||
| To update those files with the latest set of browsers that BrowserStack support, you should run: | ||
|
|
||
| `$ npm run update-browserstack-list` | ||
|
|
||
| If the command is successful then your terminal will respond: | ||
|
|
||
| ``` | ||
| Updated the browser list for automated testing via BrowserStack. | ||
| ``` | ||
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On 06 October 2021 BrowserStack deprecated and removed the Samsung Galaxy Note 4-4.4
This pull-request updates our device list to the latest devices and browsers that BrowserStack support
Other pull-requests will be blocked until we update our device list to not include Samsung Galaxy Note 4-4.4