Enable GitHub's "Approve and run" button to appear on pull-requests from forks #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeChampion
changed the title
…rom forks We used a push trigger because that meant we could push the commits that were in the fork into our repo and it would cause the workflow to run on the commits. That was a good solution when GitHub didn't have a good way to run workflows on forks, but now GitHub has the "Approve and run" (https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks) feature for pull-requests from forks. Moving to their system means we only need to press a button on the pull-request to run the workflows instead of adding the forked repo as a remote, pulling down their branch with the commits and then pushing those commits to our remote.
JakeChampion
force-pushed
the
simplify-running-workflows-for-pull-requests-from-forks
branch
from
8914667
to
dad166b
Compare
JakeChampion
deleted the
simplify-running-workflows-for-pull-requests-from-forks
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used a push trigger because that meant we could push the commits that were in the fork into our repo and it would cause the workflow to run on the commits.
That was a good solution when GitHub didn't have a good way to run workflows on forks, but now GitHub has the "Approve and run" (https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks) feature for pull-requests from forks.
Moving to their system means we only need to press a button on the pull-request to run the workflows instead of adding the forked repo as a remote, pulling down their branch with the commits and then pushing those commits to our remote.