Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String.prototype.trim incorrect safari version range #1133

Closed
cdaringe opened this issue Dec 2, 2021 · 2 comments
Closed

String.prototype.trim incorrect safari version range #1133

cdaringe opened this issue Dec 2, 2021 · 2 comments
Labels
library Relates to an Origami library

Comments

@cdaringe
Copy link
Contributor

cdaringe commented Dec 2, 2021

What

Problem

String.prototype.trim claims safari = "<12.1", which appears incorrect

Details

I suspect it should be <5 vs <12.1!

Please assert and we will send a patch

@JakeChampion
Copy link
Owner

Hi, this is due to the fact the version of unicode used in ecmascript was updated and changed what was defined as whitespace - that whitespace definition is used in string.prototypr.trim, which meant older browsers had a spec non compliant implementation, which is why we polyfill those versions.

This is the commit which updated the spec tc39/ecma262#300

@cdaringe
Copy link
Contributor Author

cdaringe commented Dec 3, 2021

Ouch! https://en.wikipedia.org/wiki/Whitespace_character#Unicode

must have been rough doing that diff

@cdaringe cdaringe closed this as completed Dec 3, 2021
Origami ✨ automation moved this from To Do to Done Dec 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2022
@robertboulton robertboulton removed this from Done in Origami ✨ Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
library Relates to an Origami library
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants