fix arraybuffer polyfill to not error in ie8 #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notlee
approved these changes
Dec 7, 2021
|
Thank you @JakeChampion! Started a run with the polyfill combinations : https://github.com/romainmenke/polyfill-library/runs/4447515393?check_suite_focus=true |
|
Seeing one failure in IE8 for TextDecoder when all polyfills are loaded.
|
|
Doing a git bisect it looks like the issue was exposed in this commit 29c6814 - I haven't found the cause yet but I'm getting closer |
|
@romainmenke This should now be fixed 👍 |
…E8 because we can't use add square-bracket notation support due to the lack of getters and setters in IE8
|
A full run is taking place on https://github.com/Financial-Times/polyfill-library/actions/runs/1554495111 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1129