Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improves localStorage polyfill to store keys as base64 #1141

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Improves localStorage polyfill to store keys as base64 #1141

merged 1 commit into from
Dec 9, 2021

Conversation

mhassan1
Copy link
Collaborator

@mhassan1 mhassan1 commented Dec 8, 2021

Resolves #669

@mhassan1 mhassan1 requested a review from a team as a code owner December 8, 2021 21:20
@origamiserviceuser origamiserviceuser added this to To Do in Origami ✨ Dec 8, 2021
@github-actions github-actions bot added the library Relates to an Origami library label Dec 8, 2021
@JakeChampion
Copy link
Owner

/ok-to-test sha=2ab99d86a2456b1c70358c7d2949d5e3803f62f7

@JakeChampion JakeChampion merged commit b89fda3 into JakeChampion:master Dec 9, 2021
Origami ✨ automation moved this from To Do to Done Dec 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2022
@mhassan1 mhassan1 deleted the localstorage-base64 branch June 30, 2023 12:41
@robertboulton robertboulton removed this from Done in Origami ✨ Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JakeChampion JakeChampion JakeChampion approved these changes

Assignees
No one assigned
Labels
library Relates to an Origami library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

localStorage.setItem polyfill throws error on keys with spaces
2 participants
@mhassan1 @JakeChampion