Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes TypedArray.prototype.at to avoid adding at to Object.prototype #1188

Merged
merged 2 commits into from
Jul 12, 2022
Merged

Fixes TypedArray.prototype.at to avoid adding at to Object.prototype #1188

merged 2 commits into from
Jul 12, 2022

Conversation

mhassan1
Copy link
Collaborator

The current logic in TypedArray.prototype.at adds at to the parent prototype of Int8Array.prototype; in IE11, this is actually Object.prototype, and we don't want to add at there. This PR checks that it is not Object.prototype; if it is, it adds at directly to Int8Array.prototype.

@mhassan1 mhassan1 requested a review from a team as a code owner May 19, 2022 01:00
@origamiserviceuser origamiserviceuser added this to Backlog in Origami ✨ May 19, 2022
@github-actions github-actions bot added the library Relates to an Origami library label May 19, 2022
@mhassan1
Copy link
Collaborator Author

@chee Is anything blocking this PR?

@romainmenke
Copy link
Collaborator

Running CI : https://github.com/Financial-Times/polyfill-library/actions/runs/2650687032

@romainmenke romainmenke mentioned this pull request Jul 11, 2022
Closed
3 tasks
@romainmenke
Copy link
Collaborator

@mhassan1 Thank you for this update!

@romainmenke romainmenke merged commit de90e2e into JakeChampion:master Jul 12, 2022
Origami ✨ automation moved this from Backlog to Done Jul 12, 2022
@mhassan1 mhassan1 deleted the at branch June 30, 2023 12:41
@robertboulton robertboulton removed this from Done in Origami ✨ Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chee chee chee left review comments

@JakeChampion JakeChampion JakeChampion approved these changes

Assignees
No one assigned
Labels
library Relates to an Origami library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mhassan1 @romainmenke @chee @JakeChampion