fix partial tests in CI and use native concurrency control #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainmenke
force-pushed
the
fix-partial-tests-in-ci--amiable-ant-a67b57f843
branch
from
de17172
to
55e2e1f
Compare
romainmenke
force-pushed
the
fix-partial-tests-in-ci--amiable-ant-a67b57f843
branch
from
55e2e1f
to
d03c676
Compare
JakeChampion
approved these changes
Jul 11, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub workflows have build in concurrency controls.
Using these means we can remove
styfle/cancel-workflow-actionandsoftprops/turnstyle. Two 3rd party actions that required access to secrets.Partial tests seem to have broken a while back because the checkout step no longer fetched
https://github.com/Financial-Times/polyfill-library/tree/master/. This is required to determine the diff.update : maybe this was done because
GITHUB_REFwas no longer valid when workflows run with apull_requestevent. The JS has been updated so that it works for any trigger.I've added a fetch depth of 50 which is much larger than usual pull requests will require but still smaller than fetching everything.