Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Node.prototype.getRootNode and Node.prototype.isConnected polyfills #1223

Merged
merged 2 commits into from
Aug 13, 2022
Merged

Adds Node.prototype.getRootNode and Node.prototype.isConnected polyfills #1223

merged 2 commits into from
Aug 13, 2022

Conversation

mhassan1
Copy link
Collaborator

This PR adds polyfills for Node.prototype.getRootNode and Node.prototype.isConnected. It is based on #485 and #486.

Resolves #326.

@mhassan1 mhassan1 requested a review from a team as a code owner August 10, 2022 20:02
@origamiserviceuser origamiserviceuser added this to Backlog in Origami ✨ Aug 10, 2022
@github-actions github-actions bot added the library Relates to an Origami library label Aug 10, 2022
@romainmenke
Copy link
Collaborator

romainmenke commented Aug 13, 2022 •
edited

/ok-to-test sha=06b736f

https://github.com/Financial-Times/polyfill-library/actions/runs/2851206844

@romainmenke romainmenke merged commit 7191ef4 into JakeChampion:master Aug 13, 2022
Origami ✨ automation moved this from Backlog to Done Aug 13, 2022
@mhassan1 mhassan1 deleted the node-isconnected branch June 30, 2023 12:40
@robertboulton robertboulton removed this from Done in Origami ✨ Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeChampion JakeChampion JakeChampion approved these changes

Assignees
No one assigned
Labels
library Relates to an Origami library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature request] Add Node.prototype.isConnected
3 participants
@mhassan1 @romainmenke @JakeChampion