Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object.entries not served for Google AdsBot #127

Closed
EECOLOR opened this issue Feb 12, 2019 · 1 comment
Closed

Object.entries not served for Google AdsBot #127

EECOLOR opened this issue Feb 12, 2019 · 1 comment

Comments

@EECOLOR
Copy link

EECOLOR commented Feb 12, 2019

Our rollbar error log files show errors for Object.entries with browser AdsBot-Google (+http://www.google.com/adsbot.html). We expected Object.entries to be polyfilled.

Our api call: https://cdn.polyfill.io/v2/polyfill.min.js?features=default,es2015,es2016,es2017,fetch

After investigation it seems that the browser is not listed at the polyfill: https://github.com/Financial-Times/polyfill-library/blob/master/polyfills/Object/entries/config.json

I am not sure what the problem is, it could be:

  1. That the browser agent string is recognising it as another browser, making polyfill.io think it doesn't need it
  2. Not recognising the browser at all and thus serving no polyfills

If it is 2. I would rather have the behavior that simply serves all polyfills with detect scripts.

For completeness, here are the user agent strings of the different Google bots: https://support.google.com/webmasters/answer/1061943?hl=en

@EECOLOR
Copy link
Author

EECOLOR commented Feb 12, 2019

I just discovered unknown=polyfill

@EECOLOR EECOLOR closed this as completed Feb 12, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant