serve isIntersecting polyfill to chromium based browsers
#1283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainmenke
commented
Mar 23, 2023
| @@ -61,6 +61,7 @@ function IntersectionObserverEntry(entry) { | |||
| } | |||
| } | |||
|
|
|||
| IntersectionObserverEntry.prototype.intersectionRatio = 0; | |||
There was a problem hiding this comment.
Not ideal, but this matches the surrounding code.
Without this the polyfill doesn't pass its own feature detect.
| /* eslint-env mocha, browser */ | ||
| /* global proclaim */ | ||
|
|
||
| describe('IntersectionObserver', function () { |
There was a problem hiding this comment.
A very minimal test to ensure we have at least some indication that the polyfill works.
| @@ -2,7 +2,38 @@ | |||
| /* global proclaim */ | |||
|
|
|||
| describe('IntersectionObserverEntry', function () { | |||
| var scrollArea; | |||
There was a problem hiding this comment.
Another very minimal test, but focussed on isIntersecting
JakeChampion
approved these changes
Mar 23, 2023
|
🤔 browserstack seems to have broken something again. |
|
CI all green |
romainmenke
deleted the
isIntersecting-polyfill-for-chromium--adventurous-spadefoot-toad-9e5b11b33c
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see : #1282