-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI is broken and it seems unlikely that Browserstack will be able to resolve this on their own. #1284
Comments
I tried replicating this from my machine against my own BrowserStack, but I wasn't able to. With command • Browser: firefox/38.0 Test config: targeted / ✓ 1088 tests 65 seconds to complete
• Browser: firefox/39.0 Test config: targeted / ✓ 1082 tests 63 seconds to complete
• Browser: firefox/40.0 Test config: targeted / 91/113
• Browser: firefox/41.0 Test config: targeted / ✓ 1068 tests 60 seconds to complete
• Browser: firefox/42.0 Test config: targeted / ✓ 947 tests 56 seconds to complete
• Browser: firefox/43.0 Test config: targeted / 49/97
• Browser: firefox/44.0 Test config: targeted / 75/95
• Browser: firefox/45.0 Test config: targeted / 71/90
• Browser: firefox/46.0 Test config: targeted / ✓ 909 tests 51 seconds to complete
• Browser: firefox/47.0 Test config: targeted / 51/88 Is there something else I should do to replicate? |
Thank you for checking @mhassan1 🙇 This at least gives some indication that CI can still pass. |
Re-tested :
All are failing on exactly Firefox 45 with the same error. The Firefox 45 session, was it running on Windows XP or a different OS, OS version? |
Interesting, that is not what I am seeing on my end : The browser never even starts as you can see in the video. |
@notlee and/or @wheresrhys - could you let us know the FT BrowserStack plans please? |
Maybe something specific about sponsored accounts? |
I've been reminding Browserstack of these issues regularly and got some good news today :
I've rerun some tests here and CI seems fine again 🎉 |
see : https://github.com/Financial-Times/polyfill-library/actions/runs/4501232331/jobs/8176234150
I know that Browserstack is rolling out breaking changes to their platform.
This is a gradual roll out, older browser versions seem to update first.
I've already reached out to them and asked them to provide more info on this.
This is a slow and frustrating process because everything goes through non-technical support. It is impossible to contact an engineer and just get a direct answer on what is going on.
The most clear info I have gotten is that they are removing a lot of heuristics around the capabilities which need to be set. In the past it was fine to just request a session with a specific browser name and browser version. Now a lot more needs to be set, all driver versions, machine type, ... Without these the service is either flaky or plain broken. I don't know why these heuristics are being removed. It is very difficult to manually configure everything correctly for the large number of browsers and browser versions we test here.
One way I worked around this in other projects was by setting a flag to make sure the w3c standard protocol wasn't used. This seemed to trigger the old heuristics to kick in again. This no longer seems to work.
It is possible that they have moved on to a next step in these changes and that the current breakage is not caused by these capabilities, but by something else.
I don't currently have time to really debug this all over again and find out what the issues are this time and I also don't have time to hop on a call with Browserstack support and show that the issues are real.
Is there anyone with a Browserstack account and a setup of the CI for the
polyfill-library
that is willing to spend time on this?The text was updated successfully, but these errors were encountered: