-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds change-array-by-copy
polyfills
#1285
Adds change-array-by-copy
polyfills
#1285
Conversation
Array.prototype.toReversed Array.prototype.toSorted Array.prototype.toSpliced Array.prototype.with %TypedArray%.prototype.toReversed %TypedArray%.prototype.toSorted %TypedArray%.prototype.with
/ok-to-test sha=cf9230b |
CI running here: https://github.com/Financial-Times/polyfill-library/actions/runs/4724256232 CI is likely still broken, but maybe it also has useful feedback :) |
/ok-to-test sha=cab69e6 https://github.com/Financial-Times/polyfill-library/actions/runs/4762911502 |
There are a bunch of failures:
All of these have been fixed except
|
Thanks for the detailed write-up! I'm in favour of option 2. It has precedent as we took that option for Promise.prototype.finally as well -- https://github.com/Financial-Times/polyfill-library/blob/master/polyfills/Promise/prototype/finally/config.toml#L9 |
I've added |
/ok-to-test sha=bde70e8 |
I've addressed a couple more failures:
This is ready for re-test. |
/ok-to-test sha=22b3791 |
CI all green 🎉 |
This PR adds the following ES2023 polyfills:
Array.prototype.toReversed
Array.prototype.toSorted
Array.prototype.toSpliced
Array.prototype.with
%TypedArray%.prototype.toReversed
%TypedArray%.prototype.toSorted
%TypedArray%.prototype.with