Adds String.prototype.isWellFormed and String.prototype.toWellFormed
#1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeChampion
approved these changes
Jul 5, 2023
|
@JakeChampion @romainmenke Is this ready for merge? |
Yep! I'll merge now, after someone with write access has approved the PR and nothing is left outstanding to answer/change, you should be good for merging. I believe you should have merge abilities, if you don't, let's fix that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds polyfills for
String.prototype.isWellFormedandString.prototype.toWellFormed.It also refactors
String.fromCodePoint,String.prototype.codePointAt, and_ESAbstract.AdvanceStringIndexto use new abstracts:UTF16EncodeCodePoint(which replacesUTF16Encoding),UTF16SurrogatePairToCodePoint(which replacesUTF16Decode), andCodePointAt.