Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small refactorings #1313

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

small refactorings #1313

wants to merge 10 commits into from

Conversation

JakeChampion
Copy link
Owner

@JakeChampion JakeChampion commented Aug 16, 2023

@@ -43,7 +31,7 @@
},
"license": "MIT",
"engines": {
"node": ">=12"
"node": ">=18"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change implies a new semver major release.

Should we skip 18 and go straight to 20?
20 will reach LTS in ±2 months which isn't that far out. Node 20 will be supported until 2026-04-30.


Are there other things that should be changed before releasing this?
I started a list once but never did a sweep of the codebase to gather more items : #1206

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do wonder if we should think about dropping support for IE 9 and possibly IE 10 -- However I don't have stats I can look at to help make that decision

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

I can share some stats and can also take a look at the stuff the webdx group has been investigating. But I am fairly certain that anyone needing to support IE 9 / 10 can continue to use an older version of the library.


We should do the same for old browser versions of other vendors.
IE 11 was released in 2013, maybe we can align around this?

Last release of Chrome in 2013 was 31, which is not that far from the current version which is 29.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should do the same for old browser versions of other vendors.
IE 11 was released in 2013, maybe we can align around this?

I like this a lot 👍

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll move this to an issue somewhere tomorrow 👍

Copy link
Collaborator

@romainmenke romainmenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants