Use caches for getPolyfillMeta, listAliases, and listPolyfills #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 27, 2019 10:38
…ilesystem operations
…ver are functions which always return the exact same result
bringking
reviewed
Feb 27, 2019
| return readFile(path.join(polyfillDirectory, "aliases.json")).then(JSON.parse); | ||
| } | ||
| const listAliases = (function() { | ||
| const aliases = readFile(path.join(polyfillDirectory, "aliases.json")).then(JSON.parse); |
There was a problem hiding this comment.
Thanks for the review :-)
|
@JakeChampion, this is great. Thank you! Any particular reason you want to avoid using require? Just curious |
bringking
approved these changes
Feb 27, 2019
|
@bringking avoiding require is because it is a blocking call if it is the first time the file is being required. If polyfill-library is used on a HTTP server and that blocking call happened, it would stop other requests from being handled at the same moment in time. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #147
Resolves #148