-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Object.assign window.location in IE11 Bug #17
Comments
I have same issue |
I found that if the window.location put as first argument, then everything works Object.assign(window.location, {}) Also, if i change function that provided by polyfill-service to function that provided by babel, everything works too. function assign(target) {
for (var i = 1; i < arguments.length; i++) {
var source = arguments[i];
for (var key in source) {
if (Object.prototype.hasOwnProperty.call(source, key)) {
target[key] = source[key];
}
}
}
return target;
} |
Thanks for the excellent bug report, it is great to see a reproducible test case. Looking into this it is also broken with the latest version of the service, I was hoping the new polyfill would have fixed it. I'll have to set aside some time to find the root cause. |
Thanks for looking into it. We had to disable Object.assign from polyfill.io and hardcode it for all users. Not ideal but it works |
This was fixed in #155 and published in https://github.com/Financial-Times/polyfill-library/releases/tag/v3.32.0 |
It looks like in IE11, trying to do the following results in an error.
This pattern is currently used by https://github.com/reach/router for example, breaking our pages in IE11
I've created a JSBin to highlight the issue
https://jsbin.com/yigocowero/1/edit?html,console
The text was updated successfully, but these errors were encountered: