Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend support of IntersectionObserver for Opera Mini #175

Merged
merged 2 commits into from
Mar 28, 2019

Conversation

matzimowski
Copy link
Contributor

fixes #173

@JakeChampion
Copy link
Owner

Hi @matzimowski, have you tested whether the polyfill does infact work in those browsers?

@matzimowski
Copy link
Contributor Author

matzimowski commented Mar 28, 2019

Hi @JakeChampion
I have used some emulator to check it (usage is described here: https://dev.opera.com/articles/installing-opera-mini-on-your-computer/)

you can see the user agent below:
Screenshot 2019-03-28 at 11 05 46

I've used IntersectionObserver in some SSR project and page was not working well:
Screenshot 2019-03-28 at 11 07 59

but when I changed from features=IntersectionObserver,... to features=IntersectionObserver|always,... it started working properly:

Screenshot 2019-03-28 at 11 12 05

Unfortunately, I didn't manage to find a device to verify it manually.

@JakeChampion
Copy link
Owner

Emulators are perfectly good to use for testing this type of work, I use all the emulators on BrowserStack for testing :-)

Thanks for showing me that it does work, I feel confident accepting this change now 👍

@JakeChampion JakeChampion merged commit e230d75 into JakeChampion:master Mar 28, 2019
@matzimowski
Copy link
Contributor Author

@JakeChampion thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend IntersectionObserver polyfill support for Opera Mini
2 participants