Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Object.values browser versions #185

Merged
merged 4 commits into from
Jun 19, 2019
Merged

Update Object.values browser versions #185

merged 4 commits into from
Jun 19, 2019

Conversation

radeno
Copy link
Contributor

@radeno radeno commented Apr 4, 2019

JakeChampion
JakeChampion requested changes Jun 19, 2019
View reviewed changes
polyfills/Object/values/config.json Outdated
"edge": "<15",
"edge_mob": "<15",
"ie": "9 - 14",
"edge": "< 12",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be <14 according to MDN.
image

Suggested change
"edge": "< 12",
"edge": "< 14",

polyfills/Object/values/config.json Outdated
"edge_mob": "<15",
"ie": "9 - 14",
"edge": "< 12",
"edge_mob": "< 12",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"edge_mob": "< 12",
"edge_mob": "< 14",

polyfills/Object/values/config.json Outdated
"ios_saf": "*",
"ios_chr": "< 54",
"safari": "< 10.1",
"ios_saf": "< 10.1",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be < 10.3 according to MDN
image

Suggested change
"ios_saf": "< 10.1",
"ios_saf": "< 10.3",

@radeno
Copy link
Contributor Author

radeno commented Jun 19, 2019

@JakeChampion You are right. CanIUse shows bad versions. I have pushed PR to their repo.
Official info https://docs.microsoft.com/en-us/microsoft-edge/dev-guide/whats-new/edgehtml-14
Edge mobile embed system rendering engine. So it is questionable if version 14 supports it or not.

@JakeChampion JakeChampion merged commit 6771179 into JakeChampion:master Jun 19, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JakeChampion JakeChampion JakeChampion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@radeno @JakeChampion