Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] Is there any change to split this library into polyfill-library and polyfill-list #199

Closed
sleagon opened this issue May 5, 2019 · 3 comments
Labels
library Relates to an Origami library

Comments

@sleagon
Copy link
Contributor

sleagon commented May 5, 2019

We have been using this library since last year, when this library was still a part of polyfill-service. We believe the most valuable thing this library provides is the polyfills, not the getter. We need to custom the UA parser to avoid some edge cases we run into. Based on the pure polyfill list, anyone can write their getter as they need. Of cause standard is necessary, anyone can provide polyfills according your standard.

This is just a simple advice, thanks for your guys nice work.

@chee
Copy link
Collaborator

chee commented May 7, 2019

Hello, @sleagon, thanks for your contribution. This isn't on the roadmap right now, I'm afraid.

Would you be in a position to share the edge cases that you run into so that we can fix them in the main library and improve the service for all users?

@sleagon
Copy link
Contributor Author

sleagon commented May 7, 2019

We are using this library in production env, the user-agent parser used here is too aggressive, which want to cover as much browsers as possible. We use a relative conservative parser which can cover most famous browser like chrome/edge/firefox/safari and ignore other browsers. We think reliability is more important than extremely performance, after all, the User-Agent is too unreliable.

@sleagon
Copy link
Contributor Author

sleagon commented May 7, 2019

In China, there is so many customed browsers and webviews, we can't take risk to cover all of them.

@JakeChampion JakeChampion added this to incoming in Origami ✨ Feb 26, 2020
@JakeChampion JakeChampion added the library Relates to an Origami library label Mar 24, 2020
Origami ✨ automation moved this from incoming to complete Oct 27, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2021
@robertboulton robertboulton removed this from Done in Origami ✨ Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
library Relates to an Origami library
Projects
None yet
Development

No branches or pull requests

3 participants