Optimise CI testing for third-party-polyfills #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 4, 2019 12:44
…nto a separate function
… more readable variable names
… not for a dependency that is used within the feature (or the features dependencies).
…e not for a dependency that is used within the feature (or the features dependencies).
JakeChampion
force-pushed
the
third-party-polyfill-test-optimisation
branch
from
7d71770
to
a0773f5
Compare
chee
reviewed
Jul 5, 2019
| }).filter(thirdPartyPolyfills => thirdPartyPolyfills !== undefined); | ||
|
|
||
| const thirdPartyPolyfillHasBeenAddedOrChangedForFeature = intersection(thirdPartyPolyfillsWhichHaveBeenAddedOrChanged, thirdPartyDependenciesForFeature).length > 0; | ||
| const packageJsonHasOnlyHadThirdPartyPolyfillChangesAppliedToIt = packageJsonDependenciesChanges.every(dep => thirdPartyPolyfills.includes(dep)); |
There was a problem hiding this comment.
if polyfill-library uses a one of these third-party-polyfills itself, then updating that will not run the other tests?
There was a problem hiding this comment.
You're right! Hmm, what do you think we should do here? Not use polyfills in polyfill-library itself?
There was a problem hiding this comment.
i'm not sure, i was making sure that i'd understood that right before even thinking about it. it's a hard one
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when a change is made to the package.json file it will cause all the tests within the project to be executed in CI, which is painfully painfully slow and labor-intensive. This is a real issue for the project because we have the ability to use an npm package as the source of a polyfill (known as third-party-polyfills) and this is used more and more by contributors to the project.
We can speed up the scenario where a third-party-polyfill has been added or updated within the project by making the CI test-runner aware of the changes made within the package.json file and figure out if the changes were for a third-party-polyfill or not.