Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update targeting for Promise.prototype.finally #415

Merged
merged 6 commits into from
Jan 27, 2020

Conversation

JakeChampion
Copy link
Owner

MDN browser support table -- https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/finally#Browser_compatibility

This config is a bit hard to understand because we configure it to only target browser which have a native Promise but not a native Promise.prototype.finally, this is because browsers which do not have a native Promise will get our Promise polyfill which already includes Promise.prototype.finally

@JakeChampion JakeChampion requested a review from a team January 27, 2020 12:24
@JakeChampion JakeChampion merged commit 220889a into master Jan 27, 2020
@JakeChampion JakeChampion deleted the promise.proto.finally branch January 27, 2020 23:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants