-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] IE11 needs Object.keys for ES6 behavior #472
Comments
Actually the problem might be that polyfill.io isn't returning the Object.keys polyfill for IE11 |
Here's a bit more... https://polyfill.io/v3/polyfill.js?features=Object.keys&ua=Mozilla%2F5.0+%28compatible%3B+MSIE+10.0%3B+Windows+NT+6.1%3B+WOW64%3B+Trident%2F6.0%29 sends the polyfill. That's using the IE 10 user-agent: https://polyfill.io/v3/polyfill.js?features=Object.keys&ua=Mozilla%2F5.0+%28Windows+NT+10.0%3B+WOW64%3B+Trident%2F7.0%3B+rv%3A11.0%29+like+Gecko does not send the polyfill. That's using the IE 11 user-agent: which is weird because the config shows it should apply to all IE versions: |
Well sheesh, this has already been fixed in 1b237fb It's just not serving from polyfill.io yet |
this is now live :-) |
Thanks Jake! Unfortunately, though, fixing this just reveals that the polyfill for |
Looks like there's already an issue #218 |
What
polyfill.io doesn't return polyfill Object.keys on IE11 by default, because it has an implementation. But the native implementation is the ES5 variant which breaks various libs, for example see reduxjs/redux-toolkit#152
Details
The Object.keys polyfill supports ES6 behavior:
polyfillpolyfill/polyfill-service#991
polyfillpolyfill/polyfill-service#1033
but it's not included in the bundle for IE11
The script tag I'm using is
The text was updated successfully, but these errors were encountered: