Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several versions missing polyfills/__dist #639

Closed
jamesarosen opened this issue May 17, 2020 · 3 comments
Closed

Several versions missing polyfills/__dist #639

jamesarosen opened this issue May 17, 2020 · 3 comments

Comments

@jamesarosen
Copy link
Contributor

What

Versions 3.25.1, 3.27.4, and 3.28.1 (and possibly others) have internal dependencies on polyfills/__dist/, but that folder doesn't exist. Is it possible they were published without running a necessary build step?

Details

$ curl -O https://registry.npmjs.org/polyfill-library/-/polyfill-library-3.25.1.tgz
$ tar -ztvf polyfill-library-3.25.1.tgz | grep __dist || echo "not found"
not found
$ tar -xzvf polyfill-library-3.25.1.tgz | grep __dist || echo "not found"
$ node
> require('.')
No polyfill sources found.  Run `npm run build` to build them

$ curl -O https://registry.npmjs.org/polyfill-library/-/polyfill-library-3.27.4.tgz
$ tar -ztvf polyfill-library-3.27.4.tgz | grep __dist "not found"
not found

$ curl -O https://registry.npmjs.org/polyfill-library/-/polyfill-library-3.28.1.tgz
$ tar -ztvf polyfill-library-3.28.1.tgz | grep __dist "not found"
not found
@jamesarosen
Copy link
Contributor Author

Now that I look at the package, I see that __dist isn't supposed to be included. It's supposed to get created as part of postinstall. That step must be failing for me. I'll try to find out why.

@jamesarosen
Copy link
Contributor Author

jamesarosen commented May 17, 2020

Possibly helpful:

$ npm install
…
npm WARN lifecycle polyfill-library@3.25.1~postinstall: cannot run in wd polyfill-library@3.25.1 npm run build (wd=/polyfill/node_modules/polyfill-library-3.25.1)
npm WARN lifecycle polyfill-library@3.27.4~postinstall: cannot run in wd polyfill-library@3.27.4 npm run build (wd=/polyfill/node_modules/polyfill-library-3.27.4)
npm WARN lifecycle polyfill-library@3.28.1~postinstall: cannot run in wd polyfill-library@3.28.1 npm run build (wd=/polyfill/node_modules/polyfill-library-3.28.1)
npm WARN lifecycle polyfill-service@4.28.1~prepare: cannot run in wd polyfill-service@4.28.1 npm run snyk-protect (wd=/polyfill)

I believe wd is wd. Installing that seems to have fixed the issue.

Origami ✨ automation moved this from incoming to complete May 17, 2020
@jamesarosen jamesarosen reopened this May 17, 2020
Origami ✨ automation moved this from complete to active May 17, 2020
@jamesarosen
Copy link
Contributor Author

jamesarosen commented May 18, 2020

I misread the error. It's not trying to run wd. It's telling me that's the working directory. This was a permissions problem.

Origami ✨ automation moved this from active to complete May 18, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2020
@robertboulton robertboulton removed this from Done in Origami ✨ Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant