Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace smoothscroll with seamless-scroll-polyfill #657

Closed
jamesarosen opened this issue May 29, 2020 · 2 comments · Fixed by #659
Closed

Replace smoothscroll with seamless-scroll-polyfill #657

jamesarosen opened this issue May 29, 2020 · 2 comments · Fixed by #659

Comments

@jamesarosen
Copy link
Contributor

jamesarosen commented May 29, 2020 •
edited

Possibly a bug?

What

The current smoothscroll library, smoothscroll-polyfill, doesn't support the block and inline options. iamdustan/smoothscroll#87 suggests that it's no longer maintained. seamless-scroll-polyfill is a better-maintained fork that complies with more of the spec.
@origamiserviceuser origamiserviceuser added this to incoming in Origami ✨ May 29, 2020
@jamesarosen
Copy link
Contributor Author

I'm happy to attempt a PR if there's interest.

@JakeChampion
Copy link
Owner

@jamesarosen yes please :-)

@jamesarosen jamesarosen mentioned this issue May 29, 2020
Merged
Origami ✨ automation moved this from incoming to complete Jun 2, 2020
JakeChampion pushed a commit that referenced this issue Jun 2, 2020
@JakeChampion
Use seamless-scroll-polyfill for smoothscroll
32a9eb5 
Previously, polyfill-library used smoothscroll-polyfill. That library is no longer
well-maintained and is missing some parts of the smoothscroll spec.

This commit swaps in seamless-scroll-polyfill, which is a better-maintained fork
of smoothscroll-polyfill.

Resolves #657
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2020
@robertboulton robertboulton removed this from Done in Origami ✨ Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use seamless-scroll-polyfill for smoothscroll
2 participants
@jamesarosen @JakeChampion