Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible typo in HTMLCanvasElement.prototype.toBlob config #836

Closed
romainmenke opened this issue Aug 23, 2020 · 2 comments
Closed

Possible typo in HTMLCanvasElement.prototype.toBlob config #836

romainmenke opened this issue Aug 23, 2020 · 2 comments
Labels
library Relates to an Origami library

Comments

@romainmenke
Copy link
Collaborator

https://github.com/Financial-Times/polyfill-library/blob/6f6b6de298e16eddc616692c2cd5bdd2495bf272/polyfills/HTMLCanvasElement/prototype/toBlob/config.toml#L1

aliases = [ "HTMLCanvasElement.protoype.toBlob" ]

protoype

Noticed this while implementing support for aliases.
Is this config correct? If so, maybe best to document this, as it looks like an err :)
@romainmenke romainmenke changed the title Possible typo in HTMLCanvasElement.protoype.toBlob config Possible typo in HTMLCanvasElement.prototype.toBlob config Aug 23, 2020
@origamiserviceuser origamiserviceuser added this to incoming in Origami ✨ Aug 23, 2020
@github-actions github-actions bot added the library Relates to an Origami library label Aug 23, 2020
@JakeChampion
Copy link
Owner

Yep that is on purpose to maintain backwards compatibility. The original polyfill was added with the typo so we fixed the name and added the typo name as an alias

@JakeChampion
Copy link
Owner

Fixed in b394035

Thanks for the suggestion 😊

Origami ✨ automation moved this from incoming to complete Aug 23, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2021
@robertboulton robertboulton removed this from Done in Origami ✨ Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
library Relates to an Origami library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JakeChampion @romainmenke