Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update seamless-scroll-polyfill to 1.2.3 #872

Merged
merged 5 commits into from
Oct 13, 2020
Merged

Update seamless-scroll-polyfill to 1.2.3 #872

merged 5 commits into from
Oct 13, 2020

Conversation

magic-akari
Copy link
Contributor

No description provided.

@magic-akari magic-akari requested a review from a team as a code owner September 23, 2020 02:58
@CLAassistant
Copy link

CLAassistant commented Sep 23, 2020

CLA assistant check
All committers have signed the CLA.

@origamiserviceuser origamiserviceuser added this to incoming in Origami ✨ Sep 23, 2020
@github-actions github-actions bot added the library Relates to an Origami library label Sep 23, 2020
@JakeChampion
Copy link
Owner

Hi @magic-akari, thank you for the pull-request.

We've ran the tests on many browsers and some of them are failing, would you be able to fix these at all?

Failures:
 - ie/10.0:
    -> smoothscroll passes the feature detect
       false == true
 - ie/11.0:
    -> smoothscroll passes the feature detect
       false == true
 - ie/9.0:
    -> smoothscroll passes the feature detect
       false == true
 - ie/9.0:
    -> Element.prototype.inert inert set
       Unspecified error.

To run the tests:

@magic-akari magic-akari changed the title Update seamless-scroll-polyfill to 1.2.2 Update seamless-scroll-polyfill to 1.2.3 Sep 27, 2020
@magic-akari
Copy link
Contributor Author

It seems that the function Number.isNaN I used is not listed in the dependencies.
I have fixed it by removing this function.

@magic-akari
Copy link
Contributor Author

magic-akari commented Oct 12, 2020

I have fixed it. Would you mind rerun the tests?

package.json Outdated Show resolved Hide resolved
@JakeChampion JakeChampion merged commit 6cf9683 into JakeChampion:master Oct 13, 2020
Origami ✨ automation moved this from incoming to complete Oct 13, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2021
@robertboulton robertboulton removed this from Done in Origami ✨ Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
library Relates to an Origami library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants