Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for Array
IE8
IE8 does not get the
Symbol.prototype.description
polyfill.IE9-11
Array.prototype.@@iterator
fail will be fixed with a Symbol refactor [3]Array.prototype.entries
fail will be fixed with a Symbol refactor [3]Array.prototype.keys
fail will be fixed with a Symbol refactor [3]Other browsers
did some spot tests for older chrome/firefox/safari versions
These show the same results as IE9-11.
Notes :
(1)
Array.prototype.flat
usesToInteger
which lacked a check for Symbol.This test is skipped when
self.Symbol
doesn't exist.(2)
Array.prototype.sort
has a fix for stable sorting.This uses a
for .. in
iteration which didn't have a check forownProperty
.On master :
This is not ideal, but didn't throw before.
When all polyfills are loaded and
Array.prototype
is fully polyfilled it does throw when handing one of the inherited properties.(3)
Symbol.iterator
is undefined becauseSymbol.prototype.description
uses a wrapper to intercept the arguments.This wrapper does not restore the static methods on
Symbol
.Symbol.iterator
being missing breaks someArray
methods which rely on iterators.This will not be fixed in this branch.