Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is the big one
I am not very confident about this code and this change might introduce new bugs :/
What I wanted to do :
Symbol
polyfill to browsers that really need it. Not to every browser that needsSymbol.prototype.description
Symbol.prototype.description
in all supported browsersThe only way I could think of to do that, was by using a
Proxy
in modern browsers.This does introduces duplicate logic and duplicate tests.
I am definitely not an expert on
Symbol
and might have overlooked nuances when mangling the code for both polyfills.ci is still running for this one : reference branch