update polyfill configs for edge 79 + a few corrections #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainmenke
commented
Dec 13, 2020
| @@ -12,8 +12,8 @@ docs = "https://developer.mozilla.org/en-US/docs/Web/API/Element/matches" | |||
| spec = "http://dom.spec.whatwg.org/#dom-element-matches" | |||
|
|
|||
| [browsers] | |||
| edge = "<18" | |||
| edge_mob = "<18" | |||
| edge = "<15" | |||
There was a problem hiding this comment.
manually tested in Edge 15,16,17 and tests pass for each without loading the polyfill.
romainmenke
commented
Dec 13, 2020
| @@ -5,8 +5,8 @@ repo = "https://github.com/scottjehl/picturefill" | |||
| docs = "https://developer.mozilla.org/en-US/docs/Web/HTML/Element/picture" | |||
|
|
|||
| [browsers] | |||
| edge = "<12" | |||
| edge_mob = "<12" | |||
| edge = "<13" | |||
There was a problem hiding this comment.
MDN states Edge 13 as the first version with support
romainmenke
deleted the
update-polyfill-configs-for-edge-79--empathetic-stick-insect-1c83f2255c
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of polyfills still have
edge = "*"Compared each with MDN and update to
<79.