Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the
smoothscroll
polyfill wasn't patching properly in Safari when using the polyfill-service. The first part of the detect logic returnsfalse
(indicating the need for the polyfill), while the second returnstrue
. However, when wrapping the detect logic with!()
for the?flags=gated
case, it evaluates tofalse
due to the||
operator.This PR updates the logic from
||
to&&
.Please let me know if there is any more info I can provide or things I forgot to address with this PR.