Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URLSearchParams: firefox needs polyfill up to 53 #983

Merged
merged 1 commit into from
Jan 24, 2021
Merged

URLSearchParams: firefox needs polyfill up to 53 #983

merged 1 commit into from
Jan 24, 2021

Conversation

romainmenke
Copy link
Collaborator

URLSearchParams.prototype.toString should have been implemented in Firefox 29 according to MDN

In practice you get [Object Object] URL encoded.
From Firefox 54 this works natively.

URLSearchParams.prototype.sort was also implemented in Firefox 54 which just happens to align with this fix.

Browser log in Firefox 53 :

Screenshot 2021-01-22 at 19 41 00

Test run without polyfills in Firefox 53 :

Screenshot 2021-01-22 at 19 42 35

Test results for which show the range where URLSearchParams.prototype.toString works :

Screenshot 2021-01-22 at 19 45 55

@romainmenke romainmenke requested a review from a team as a code owner January 22, 2021 18:52
@github-actions github-actions bot added the library Relates to an Origami library label Jan 22, 2021
@origamiserviceuser origamiserviceuser added this to incoming in Origami ✨ Jan 22, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jan 22, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JakeChampion
Copy link
Owner

Thanks @romainmenke, running on CI now 👍

Origami ✨ automation moved this from incoming to active Jan 22, 2021
@JakeChampion JakeChampion enabled auto-merge (rebase) January 22, 2021 18:55
@romainmenke romainmenke mentioned this pull request Jan 22, 2021
Closed
@JakeChampion JakeChampion merged commit e57c032 into JakeChampion:master Jan 24, 2021
Origami ✨ automation moved this from active to complete Jan 24, 2021
@romainmenke romainmenke deleted the firefox-needs-urlsearchparams-polyfill-up-to-53--inventive-fly-ff7c222c6b branch January 24, 2021 15:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 25, 2022
@robertboulton robertboulton removed this from Done in Origami ✨ Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JakeChampion JakeChampion JakeChampion approved these changes

Assignees
No one assigned
Labels
library Relates to an Origami library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romainmenke @JakeChampion