Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump eslint-plugin-unicorn from 26.0.1 to 27.0.0 #988

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 2, 2021

Bumps eslint-plugin-unicorn from 26.0.1 to 27.0.0.

Release notes

Sourced from eslint-plugin-unicorn's releases.

v27.0.0

New rules

Improvements

  • prefer-ternary: Add only-single-line option (#1025) 306c9e7
  • numeric-separators-style: Add onlyIfContainsSeparator option (#916) 8d32574
  • prefer-spread: Prefer ... over Array#concat() (#1029) cda72bd
  • prefer-spread: Fix more .concat cases (#1042) c3c7ba3
  • no-array-callback-reference: Improve suggestions for Array#forEach() (#1049) 77bcdc6
  • no-new-buffer: Use suggestion for unknown arguments (#1037) 88a724c
  • no-unreadable-array-destructuring: Add auto-fix (#1010) 27bc3c3
  • new-for-builtins: Better auto-fix (#1022) 5ba0f83
  • no-instanceof-array: Better auto-fix (#1020) 0520f31

Fixes

  • prefer-query-selector: Fix crash on unexpected selector (#1034) 88018ca

sindresorhus/eslint-plugin-unicorn@v26.0.1...v27.0.0

Commits
  • 3765807 27.0.0
  • c3c7ba3 prefer-spread: Fix more .concat cases (#1042)
  • f5496c7 Refactor: remove eslint-ast-utils package (#1048)
  • 77bcdc6 no-array-callback-reference: Improve suggestions for Array#forEach() (#1049)
  • 4271e95 no-array-for-each: Add auto-fix for some wrongly detected case (#1043)
  • a091842 Use @babel/eslint-parser in tests (#961)
  • 88a724c no-new-buffer: Use suggestion for unknown arguments (#1037)
  • db5a068 no-array-for-each: Fix broken auto-fixed code (#1039)
  • ca2f54f Refactor: replace isSameNode with hasSameRange (#1036)
  • cda72bd prefer-spread: Prefer ... over Array#concat() (#1029)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually

@dependabot dependabot bot requested a review from a team as a code owner February 2, 2021 00:28
@dependabot dependabot bot added the dependencies This is maintenance work relating to dependency bumps label Feb 2, 2021
@origamiserviceuser origamiserviceuser added this to incoming in Origami ✨ Feb 2, 2021
@github-actions github-actions bot added the library Relates to an Origami library label Feb 2, 2021
Origami ✨ automation moved this from incoming to active Feb 2, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 11, 2021

A newer version of eslint-plugin-unicorn exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@JakeChampion JakeChampion requested review from JakeChampion and removed request for a team February 11, 2021 15:34
Copy link
Collaborator

@romainmenke romainmenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like there were some cases where .concat was used with a string instead of an array. Updating the code to use the spread operator resulted in strings being converted to Arrays with chars as elements.

Still something else going wrong :)

tasks/buildsources/flatten-polyfill-directories.js Outdated Show resolved Hide resolved
tasks/buildsources.js Outdated Show resolved Hide resolved
tasks/buildsources.js Outdated Show resolved Hide resolved
tasks/buildsources/write-alias-file.js Outdated Show resolved Hide resolved
dependabot bot and others added 7 commits March 19, 2021 11:26
Co-authored-by: Romain Menke <11521496+romainmenke@users.noreply.github.com>
Co-authored-by: Romain Menke <11521496+romainmenke@users.noreply.github.com>
Co-authored-by: Romain Menke <11521496+romainmenke@users.noreply.github.com>
Co-authored-by: Romain Menke <11521496+romainmenke@users.noreply.github.com>
Co-authored-by: Romain Menke <11521496+romainmenke@users.noreply.github.com>
@JakeChampion JakeChampion force-pushed the dependabot/npm_and_yarn/eslint-plugin-unicorn-27.0.0 branch from 95dcef5 to 937b822 Compare March 19, 2021 11:29
@JakeChampion JakeChampion enabled auto-merge (rebase) March 19, 2021 12:09
@JakeChampion JakeChampion merged commit e30ecbd into master Mar 19, 2021
Origami ✨ automation moved this from active to complete Mar 19, 2021
@JakeChampion JakeChampion deleted the dependabot/npm_and_yarn/eslint-plugin-unicorn-27.0.0 branch March 19, 2021 12:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2022
@robertboulton robertboulton removed this from Done in Origami ✨ Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies This is maintenance work relating to dependency bumps library Relates to an Origami library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants