Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce omit and cwd flags, expose JS API, provide custom hostname #283

Closed
wants to merge 9 commits into from
Closed

feat: introduce omit and cwd flags, expose JS API, provide custom hostname #283

wants to merge 9 commits into from

Conversation

antongolub
Copy link
Contributor

@antongolub antongolub commented Oct 10, 2022 •
edited

  • introduce omit option to suppress false-positive matches in case some custom polyfill is already present in the bundle or provided another way.
  • add cwd option to avoid cd (monorepo build case)
  • provide hostname customization
  • introduce flags, useComputeAtEdgeBackend and unknown options
  • expose analyse JS API
  • add some tests for the CLI

@antongolub antongolub requested a review from a team as a code owner October 10, 2022 20:30
@origamiserviceuser origamiserviceuser added this to Backlog in Origami ✨ Oct 10, 2022
@github-actions github-actions bot added the cli Relates to an Origami cli label Oct 10, 2022
@antongolub antongolub changed the title feat: introduce omit flag feat: introduce omit and cwd flags, expose JS API, provide custom hostname Oct 10, 2022
@antongolub
Copy link
Contributor Author

antongolub commented Oct 15, 2022 •
edited

Hey, @JakeChampion,

Could you take a look? Any chance to land this?

JakeChampion
JakeChampion approved these changes Oct 15, 2022
View reviewed changes
Copy link
Owner

@JakeChampion JakeChampion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@JakeChampion
Copy link
Owner

This'll need someone from @financial-times/origami-core to approve, merge, and release

@JakeChampion JakeChampion mentioned this pull request Jun 12, 2023
Merged
Origami ✨ automation moved this from Backlog to Done Jun 12, 2023
@JakeChampion
Copy link
Owner

Thanks for this @antongolub - the PR needed to be rebased, but I couldn't push to your fork, so I raised a new rebased PR with your changes (still attributed to you in the commit history) #290

@robertboulton robertboulton removed this from Done in Origami ✨ Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeChampion JakeChampion JakeChampion approved these changes

Assignees
No one assigned
Labels
cli Relates to an Origami cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@antongolub @JakeChampion