Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: OnTenantNotResolved not called correctly (#628) #729

Merged
merged 1 commit into from Dec 21, 2023
Merged

bug: OnTenantNotResolved not called correctly (#628) #729

merged 1 commit into from Dec 21, 2023

Conversation

thatgoofydev
Copy link
Contributor

As mentioned in #628 OnTenantNotResolved does not get called correctly when no identifier is found in any strategy.

I added tests to cover this event as well as the OnTenantResolved event.

@thatgoofydev
Copy link
Contributor Author

@dotnet-policy-service agree

@AndrewTriesToCode
Copy link
Sponsor Contributor

Thanks!

@marcelbeutner
Copy link

Hi, are there any plans to commit it in main?
Thanks!

@AndrewTriesToCode AndrewTriesToCode merged commit a26081c into Finbuckle:main Dec 21, 2023
10 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 21, 2023
@semantic-release-bot
chore: 6.13.0 [skip ci]
5b9116c 
## [6.13.0](v6.12.0...v6.13.0) (2023-12-21)

### Features

* .net8.0 LTS release support ([#770](#770)) ([d7f08f9](d7f08f9))

### Bug Fixes

* OnTenantNotResolved not called correctly ([#729](#729)) ([a26081c](a26081c)), closes [#628](#628)
@AndrewTriesToCode
Copy link
Sponsor Contributor

🎉 This PR is included in version 6.13.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thatgoofydev @AndrewTriesToCode @marcelbeutner