Memory leak due to Arc cycles

[TheButlah]

Hi, I've been reading through the codebase. It looks like SubsystemDescriptors hold Arc<SubsystemData>. And the SubsystemData holds the subsystem descriptors (without an Arc). Doesn't this mean that even if the parent subsystem is dropped, there will be a cyclic reference between a SubsystemDescriptor and a SubsystemData? So neither gets dropped and the memory is leaked

[TheButlah]

Edit: I misunderstood what was happening. A SubsystemData holds its children's SubsystemDescriptors, not its own.

[Finomnis]

No problem, thanks for reporting anyway :)

I run a full LLVM leak detection in the CI to catch those corner cases, and so far they didn't complain :)

Working on a full rewrite though, that (hopefully) will make the code structure a little clearer and more extensible.