Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make errors types adjustable #21

Closed
Finomnis opened this issue Apr 20, 2022 · 4 comments · Fixed by #27
Closed

Make errors types adjustable #21

Finomnis opened this issue Apr 20, 2022 · 4 comments · Fixed by #27

Comments

@Finomnis
Copy link
Owner

Currently everything is a Box<dyn Error>, but as default template arguments for classes exist, we might make that a template argument with the default to Box<dyn Error>.

Reasoning is that this simplifies passing errors from subsystems to this crate and back to the user again, without the user having to resort to weird runtime matching to get the original error type back.
@Finomnis
Copy link
Owner Author

This was a suggestion by @TheButlah in #13.

This was referenced May 7, 2022
Closed
Merged
@Finomnis
Copy link
Owner Author

Finomnis commented May 7, 2022

@TheButlah what's your opinion about this?

@Finomnis Finomnis reopened this May 7, 2022
@Finomnis
Copy link
Owner Author

Finomnis commented May 7, 2022

Released as 0.8.0-beta.0.
Feedback appreciated.

@Finomnis
Copy link
Owner Author

Released as 0.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make error type configurable Finomnis/tokio-graceful-shutdown
1 participant
@Finomnis