Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(code-hygiene) Use the constants #72

Open
0Tech opened this issue Feb 15, 2023 · 0 comments
Open

(code-hygiene) Use the constants #72

0Tech opened this issue Feb 15, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@0Tech
Copy link

0Tech commented Feb 15, 2023

          Please use the corresponding constant.
    amount: coins(250000, simapp.denomFee),

It would be nice to create an issue on it.

Originally posted by @0Tech in #71 (comment)

The following magic strings should be replaced. It's not exhaustive.

  • "cony" -> simapp.denomFee
  • "stake" -> simapp.denomStake
  • "link" -> simapp.prefix
@0Tech 0Tech added the good first issue Good for newcomers label Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant